Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #6340

Merged
merged 6 commits into from
May 7, 2024
Merged

Build fixes #6340

merged 6 commits into from
May 7, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented May 7, 2024

Fixes #6350

  • Added types to package json (typescript type checking gets types from exports)
  • Remapped node_modules folder to modules in unbundled build (fixes tsnode cjs issue)
  • Changed examples to use narrower build target (unbundled only)

@kpal81xd kpal81xd self-assigned this May 7, 2024
@kpal81xd kpal81xd requested a review from a team May 7, 2024 13:15
@kpal81xd kpal81xd added the bug label May 7, 2024
@kpal81xd kpal81xd requested a review from marklundin May 7, 2024 13:26
@kpal81xd kpal81xd merged commit 9b9285f into main May 7, 2024
7 checks passed
@kpal81xd kpal81xd deleted the build-fixes branch May 7, 2024 14:05
@kpal81xd kpal81xd mentioned this pull request May 14, 2024
slimbuck pushed a commit to slimbuck/engine that referenced this pull request May 20, 2024
* added types to pkg json

* modified examples first build with no engine targets

* transform node_modules folder name to modules for ts-node fix

* converted function to single line

* changed examples build to use unbundled

* fixed types output path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not loading TypeScript types definitions due to problematic "exports" field in package.json
3 participants