Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uniform buffer based skinning and batching #6324

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Remove uniform buffer based skinning and batching #6324

merged 2 commits into from
Apr 30, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 30, 2024 •
edited
Loading

WebGPU and WebGL2 support texture based skinning, and so the limited uniform buffer skinning and batching used for some WebGL1 devices is removed.

@mvaligursky mvaligursky self-assigned this Apr 30, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Apr 30, 2024
@mvaligursky mvaligursky requested a review from a team April 30, 2024 13:39
willeastcott
willeastcott approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this go!

@mvaligursky mvaligursky merged commit c264173 into main Apr 30, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-gl1-skinning branch April 30, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvaligursky @willeastcott @slimbuck