Cleanup of WebGLGraphicsDevice to strip out WebGL1 code #6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 29, 2024 15:16
| * `WebGLRenderingContext` if WebGL 2.0 is not available. But in order for IntelliSense to be | ||
| * able to function for all WebGL calls in the codebase, we specify `WebGL2RenderingContext` | ||
| * here instead. | ||
| * The WebGL2 context managed by the graphics device. |
There was a problem hiding this comment.
This should really say Create a new WebglGraphicsDevice instance. And the class description should be update to cover what the WebglGraphicsDevice is about (including talking about the fact that it's a WebGL 2.0-based device with no support for WebGL 1.0. At this moment, the class description is copy+pasted from GraphicsDevice.
There was a problem hiding this comment.
This is not a doc for the constructor, but just a gl member. The rest is as you described already.
There was a problem hiding this comment.
Oh, yeah, not sure why I misread that. Anyway, this class should have its own class description instead of cloning the GraphicsDevice one. That comment still stands.
willeastcott
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
general cleanup