Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL device ignores WebGL1 request and always creates WebGL2 device #6297

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 26, 2024

  • WebGL device ignores WebGL1 request and always creates WebGL2 device

@mvaligursky mvaligursky self-assigned this Apr 26, 2024
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Apr 26, 2024
@mvaligursky mvaligursky requested a review from a team April 26, 2024 13:00
@kpal81xd
Copy link
Contributor

Prob worth still add a description?

@@ -21,9 +21,7 @@ const createApp = async function (deviceType) {
device = new pc.WebgpuGraphicsDevice(canvas, {});
await device.initWebGpu(rootPath + '/static/lib/glslang/glslang.js', rootPath + '/static/lib/twgsl/twgsl.js');
} else if (deviceType === 'webgl1' || deviceType === 'webgl2') {
device = new pc.WebglGraphicsDevice(canvas, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a warning if webgl1 is requested saying deprecated or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No really, we'll string it out from examples completely so it cannot be requested by the examples

@mvaligursky mvaligursky merged commit 3efce7f into main Apr 26, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-always-gl2-device branch April 26, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants