Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed UMD polyfill for pcx #6289

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Removed UMD polyfill for pcx #6289

merged 2 commits into from
Apr 25, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Apr 25, 2024 •
edited
Loading

Fixes #6287

  • Removes remapping from pcx to pc

N.B. Editor launcher needs to be updated first to check for pc MiniStats first

@kpal81xd kpal81xd self-assigned this Apr 25, 2024
@kpal81xd kpal81xd requested a review from a team April 25, 2024 15:08
@mvaligursky
Copy link
Contributor

Is this going to affect backwards compatibility?

@kpal81xd
Copy link
Contributor Author

kpal81xd commented Apr 25, 2024 •
edited
Loading

Is this going to affect backwards compatibility?

Im creating an editor PR to put it on there instead of inside the engine

@kpal81xd kpal81xd merged commit 6ecaaad into main Apr 25, 2024
7 checks passed
@kpal81xd kpal81xd deleted the umd-pcx branch April 25, 2024 15:28
mvaligursky pushed a commit that referenced this pull request May 14, 2024
@kpal81xd
removed umd polyfill for pcx (#6289)
6fdbcad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.70 Release UMD-via-import regression
3 participants
@kpal81xd @mvaligursky @willeastcott