Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to WebGPU vertex buffer setup #6274

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix to WebGPU vertex buffer setup #6274

merged 1 commit into from
Apr 23, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 23, 2024

  • a case of interleaved VBs was not handled correctly, especially visible in cases of two VBs used at the same time (as instancing or morphing). This PR handles this case correctly.
  • this fixes morphing on WebGPU and so the example is now enabled
  • WebGPU shaders do not provide reflection, and so all vertex attributes are set on the device. This has a potential of additional errors where unused attribute in VB is mapped to a location of another used attribute. This is now handled by debug checking. Example: a mesh with tangent space, which is not used, is used by instancing. Instancing maps one of its elements to the same location as tangent element, creating a validation error.

Fixes / reports issues from #6270

@mvaligursky mvaligursky merged commit 518b986 into main Apr 23, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-webgpu-vb-setup branch April 23, 2024 11:17
mvaligursky added a commit that referenced this pull request Apr 29, 2024
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants