New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPU - skip unsupported device limits when creating device #6263

Merged

mvaligursky merged 1 commit into main from mv-webgpu-windows

Apr 19, 2024

Contributor

mvaligursky commented Apr 19, 2024 •

edited

Loading

related to recent change to request maximum supported limits when creating WebGPU device
currently in Chrome Windows, two limits are exposed, but not supported to set them it seem, so skip them to avoid device creation failing. Those are not part of the official spec currently:

DOMException: Failed to execute 'requestDevice' on 'GPUAdapter': The limit "minSubgroupSize" is not recognized.
    at WebgpuGraphicsDevice.initWebGpu (http://localhost:5000/iframe//ENGINE_PATH/platform/graphics/webgpu/webgpu-graphics-device.js:262:43)


          WebGPU - skip unsupported device limits when creating device

6532fb6

mvaligursky self-assigned this

mvaligursky added bug area: graphics labels

mvaligursky requested a review from a team

April 19, 2024 10:26

slimbuck approved these changes

View reviewed changes

mvaligursky merged commit d16765d into main

7 checks passed

mvaligursky deleted the mv-webgpu-windows branch

April 19, 2024 10:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics bug