Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update createTree to use correct parameters #6211

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

benbean303
Copy link
Contributor

Fixes #6196

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
Has it completely solved you issue @benbean303 ?

@mvaligursky mvaligursky added bug area: animation Animation related issue labels Apr 2, 2024
@mvaligursky mvaligursky merged commit dee9b11 into playcanvas:main Apr 2, 2024
7 checks passed
@benbean303
Copy link
Contributor Author

There's still a couple of issues when running a nested blend tree that I haven't been able to crack:

  • An error related to syncAnimations when enabled, since it's trying to blend each child's anim track but blendshapes themselves shouldn't have an assigned animation. Can be avoided by setting syncAnimations to false.
  • Similarly in the calculateWeights function, it's attempting to set the weight of each child, however blend trees do not have a setter for weight. (reference photo below)
Screenshot 2024-04-03 at 6 10 56 pm Adding a setter in resolves the error, but skeleton positions seem to collapse into their origin: Screenshot 2024-04-03 at 6 09 52 pm

I'm not sure if I'm going about this wrong or not. I've been doing most of my tests in this project: https://playcanvas.com/project/1202797/overview/blend-tree-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: animation Animation related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anim Blend Tree takes incorrect name
2 participants