Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tri class to core engine #6203

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Tri class to core engine #6203

merged 6 commits into from
Mar 27, 2024

Conversation

kpal81xd
Copy link
Contributor

  • Moved Tri class to core/math with JSDoc comments
  • Updates intersectRay to intersectsRay with ray and point arguments
  • Minor example comment Vec3 fixes

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd self-assigned this Mar 26, 2024
@kpal81xd kpal81xd requested a review from a team March 26, 2024 11:35
@mvaligursky
Copy link
Contributor

Great, but I'd suggest to move Tri class to core/shapes along the Plane and Ray.

@kpal81xd kpal81xd merged commit d12642e into main Mar 27, 2024
7 checks passed
@kpal81xd kpal81xd deleted the tri-port branch March 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants