Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix omni lights shadows on WebGPU #6165

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Mar 15, 2024

  • We were not specifying fragment shader on WebGPU if we were not writing to any color buffers. That is a problem in cases the fragment shader generates custom depth / handles alpha discard and similar. We now always specify it.
  • This fixes omni shadow rendering, as we generate custom depth
  • This fixes dithered transparency in pre-pass where only the depth buffer is updated
  • enabled clustered omni shadow example for WebGPU

Screenshot 2024-03-15 at 11 17 07
Screenshot 2024-03-15 at 11 16 54

@mvaligursky mvaligursky self-assigned this Mar 15, 2024
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Mar 15, 2024
@mvaligursky mvaligursky requested a review from a team March 15, 2024 11:23
@mvaligursky mvaligursky mentioned this pull request Mar 15, 2024
@mvaligursky mvaligursky merged commit 926bbd7 into main Mar 15, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-render-pipeline-fragment branch March 15, 2024 11:31
mvaligursky added a commit that referenced this pull request Mar 15, 2024
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants