Removes vertex-format type fix #6124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the types look correct if you remove this? Have you visual diffed the vertex-format.d.ts before and after? |
I had forgotten to add the actual changes to the commit 😅 |
|
Have you also examined how this affects the docs? |
|
Ah yeah, goes from:
To:
|
willeastcott
approved these changes
Mar 14, 2024
Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes vertex-format type fix and replaces description object with typedef of
AttributeDescriptionRequires
api-referencePR to be merged in conjunction playcanvas/api-reference#14I confirm I have read the contributing guidelines and signed the Contributor License Agreement.