Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightComponent properties port to get/set #6114

Merged
merged 28 commits into from
Mar 11, 2024
Merged

LightComponent properties port to get/set #6114

merged 28 commits into from
Mar 11, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Mar 6, 2024 •
edited
Loading

Port of LightComponent from using Object.defineProperty to using get/set

  • TS linter
  • API reference

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd changed the title LightComponent class port LightComponent properties port to get/set Mar 6, 2024
willeastcott
willeastcott reviewed Mar 6, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@kpal81xd kpal81xd marked this pull request as ready for review March 7, 2024 11:13
@kpal81xd kpal81xd self-assigned this Mar 7, 2024
@kpal81xd kpal81xd requested a review from a team March 7, 2024 11:13
@kpal81xd
Copy link
Contributor Author

kpal81xd commented Mar 7, 2024

@willeastcott I just added a comment for when I update the component to remove that data method

willeastcott
willeastcott approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor feedback.

kpal81xd and others added 4 commits March 11, 2024 16:44
@kpal81xd @willeastcott
Update src/framework/components/light/component.js
f081abf 
Co-authored-by: Will Eastcott <will@playcanvas.com>
@kpal81xd @willeastcott
Update src/framework/components/light/component.js
8d29d74 
Co-authored-by: Will Eastcott <will@playcanvas.com>
@kpal81xd @willeastcott
Update src/framework/components/light/component.js
608a08a 
Co-authored-by: Will Eastcott <will@playcanvas.com>
@kpal81xd
added ignore to light and justified comment blocks
8ab9c6e
@kpal81xd kpal81xd merged commit 001f5c1 into main Mar 11, 2024
7 checks passed
@kpal81xd kpal81xd deleted the types-fixes branch March 11, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky left review comments

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpal81xd @willeastcott @mvaligursky