-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ResourceHandler to class (Removes ts-ignore from app options) #6043
Conversation
related to #5574 |
Looks good to me besides the mentioned superfluous app assignments which are also in:
|
Just commit to fix all those rn 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! (Pls get a second approval before merging).
Fixes #5986
This PR converts the ResourceHandler interface into a class and all implementations into child classes. This removes the need to add
@ts-ignore
to each Handler used in app options in examplesI confirm I have read the contributing guidelines and signed the Contributor License Agreement.