Convert last two examples to AppBase #6038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the other particle examples use AppBase already. This will make it easier to work on the WebGPU particles implementation.
mvaligursky
reviewed
Feb 5, 2024
| const device = await pc.createGraphicsDevice(canvas, gfxOptions); | ||
| const createOptions = new pc.AppOptions(); | ||
| createOptions.graphicsDevice = device; | ||
| createOptions.mouse = new pc.Mouse(document.body); |
There was a problem hiding this comment.
I'd remove mouse / touch / element input, it does not seem the example needs any input.
mvaligursky
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the other particle examples use AppBase already. This will make it easier to work on the WebGPU particles implementation.
Fixes #6022
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.