Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples cleanup #6005

Merged
merged 16 commits into from
Jan 30, 2024
Merged

Examples cleanup #6005

merged 16 commits into from
Jan 30, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Jan 28, 2024

This PR aims to make the experience of developing and experimenting with examples easier. This will occur in two stages of which this is the first

TODO (Cleanup)

  • Fix linting issues
  • Speed up thumbnail generation
  • Maintain state for collapsing on SideBar

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd self-assigned this Jan 28, 2024
@kpal81xd kpal81xd changed the title Examples rework Examples cleanup Jan 30, 2024
@kpal81xd kpal81xd marked this pull request as ready for review January 30, 2024 14:06
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. 👍

Co-authored-by: Will Eastcott <will@playcanvas.com>
@kpal81xd kpal81xd merged commit 809921e into main Jan 30, 2024
7 checks passed
@kpal81xd kpal81xd mentioned this pull request Jan 31, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants