New GraphicsDevice.getRenderableHdrFormat function #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @returns {number|undefined} The first supported renderable HDR format or undefined if none is | ||
| * supported. | ||
| */ | ||
| getRenderableHdrFormat(formats = [PIXELFORMAT_111110F, PIXELFORMAT_RGBA16F, PIXELFORMAT_RGBA32F], filterable = true) { |
There was a problem hiding this comment.
Just wondering whether for API simplicity whether it's better to just have:
const supported = device.isRenderable(PIXELFORMAT_111110F);
There was a problem hiding this comment.
These are optional parameters, and typically the user would not pass any, to get any format from smallest size to largest.
It's similar to the device creation where we specify GL1, GL2 and GPU array in any other. Simple to call without having to implement logic on the user side.
There was a problem hiding this comment.
I already call this function twice in this code, and one more time in follow up PR .. and it's convenient to not have to implement format logic at each place.
Co-authored-by: Will Eastcott <will@playcanvas.com>
slimbuck
approved these changes
Nov 17, 2023
willeastcott
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New public API:
New public constant:
BlendState.ADDBLEND- predefined constant for additive blendingWebglGraphicsDevice. getHdrFormat