Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fixes to picker to properly set up camera #5814

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[Fix] Fixes to picker to properly set up camera #5814

merged 1 commit into from
Nov 10, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Nov 10, 2023 •
edited
Loading

Fixes playcanvas/editor#1072

  • recent refactor introduced an issue where picker was not setting up camera uniforms, and so was rendering with whatever the previous camera was
  • few other small cleanup / improvements

@mvaligursky mvaligursky self-assigned this Nov 10, 2023
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Nov 10, 2023
@mvaligursky mvaligursky merged commit 580291a into main Nov 10, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-picker-fixes branch November 10, 2023 10:58
mvaligursky added a commit that referenced this pull request Nov 10, 2023
@mvaligursky
[Fix] Fixes to picker to properly set up camera (#5814)
0c8e391 
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
# Conflicts:
#	src/scene/renderer/render-pass-render-actions.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isumygin-sc isumygin-sc isumygin-sc approved these changes

@marklundin marklundin Awaiting requested review from marklundin

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Camera gizmo has disappeared
2 participants
@mvaligursky @isumygin-sc