Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Fix shader code indentation #5811

Merged

Conversation

kungfooman
Copy link
Collaborator

I was just testing the latest Gaussian Splat example and figured the shader code received a wrong indentation:

image

Basically it happened through the last line here:

image

It happens to fit twice and then the spaces-replacement would catch a line twice. I'm sure we could also use a multiline-replacement-regex searching for "start of line", but I don't know how well supported that is across browser etc., so I just kept it somewhat simple.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks! I way prefer to indent the shaders to make it more readable when working on examples, than formatting it so that it looks fine in browser. Now we have both.

@mvaligursky mvaligursky merged commit 395c97a into playcanvas:main Nov 9, 2023
7 checks passed
@kungfooman kungfooman deleted the examples-fix-shader-code-indentation branch November 10, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants