Fix collision initialization for container assets. #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
approved these changes
Nov 7, 2023
slimbuck
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3638 and #3974.
This PR implements an additional check when using Assets that have a Container Asset on Collision components. The new code will check if the asset's
containerAssetis also loaded, and if not, load it. As noted in the linked Issues, this is required so that themeshInstancesare actually loaded on the asset.For use-cases where the Asset does not have a containerAsset or if it's already loaded, there's no change.
Sample Project with bug: https://playcanvas.com/editor/scene/1894310
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.