Make npm run build also trigger npm run build:types
#5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Oct 26, 2023
|
Thanks for this! 🙏 |
marklundin
pushed a commit
that referenced
this pull request
Nov 3, 2023
* Make `npm run build` also trigger `npm run build:types` * fix lint * fix lint 2nd time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we rimraf
/build/we don't rebuild the types, which makescd examples && npm run buildfail (because Monaco editor depends onbuild/playcanvas.d.ts).Solution is quite easy (simply trigger
npm run build:types), but side-effects for example could be increased RAM usage, so the build could fail on cheap/overused VPS servers (which struggle with RAM).I confirm I have read the contributing guidelines and signed the Contributor License Agreement.