Specify type definitions as dependencies #5766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
approved these changes
Oct 25, 2023
|
This is great, it probably means I no longer need to make module functions private if they use webgpu types in JSDocs. |
|
I believe that's correct, yes. |
marklundin
pushed a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ship type definitions for the engine that contain references to WebXR types. This means that TS projects now have to specify
@types/webxras a dependency:https://github.com/playcanvas/playcanvas-editor-ts-template/pull/12/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R34
This would be unnecessary if we just made types
dependenciesinstead ofdevDependencies.I believe the WebGPU types don't need to be
dependenciesbut, for consistency, I'm moving those todependenciestoo. It will avoid any potential future issues around WebGPU type dependencies.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.