Use subimage versions during texture update #5759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This is great @slimbuck, also I did not know this, so I've learned something new. 👏 |
marklundin
approved these changes
Oct 18, 2023
mvaligursky
approved these changes
Oct 18, 2023
marklundin
pushed a commit
that referenced
this pull request
Nov 3, 2023
* use subimage versions of texture update * lint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the texture upload logic similar to #5758.
Updating the data of an existing gl-side texture is relatively slow using
gl.texImage2Dbecause a new gl-side texture is created every time. It's faster to usegl.texSubImage2Dinstead, which will update the existing texture data.This PR requires thorough testing, especially with editor projects, to ensure edge cases are correctly covered.
Testing Notes: