Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for webpack not building #5737

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

slimbuck
Copy link
Member

Fixes #5730

Webpack was failing to build correctly after recent changes to WebGPU wasm handling.

This PR changes the glue import statement to really really dynamic so webpack will leave it be.

@slimbuck slimbuck added bug area: graphics Graphics related issue labels Oct 10, 2023
@slimbuck slimbuck requested a review from a team October 10, 2023 12:03
@slimbuck slimbuck self-assigned this Oct 10, 2023
@slimbuck slimbuck merged commit fae6a1a into playcanvas:main Oct 10, 2023
7 checks passed
@slimbuck slimbuck deleted the webpack-workaround branch October 10, 2023 15:48
mvaligursky pushed a commit that referenced this pull request Oct 12, 2023
@kungfooman kungfooman mentioned this pull request Oct 26, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical dependency: the request of a dependency is an expression - /webgpu/webgpu-graphics-device.js
2 participants