Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Don’t delete the framebuffer owned by the context #5728

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[Fix] Don’t delete the framebuffer owned by the context #5728

merged 1 commit into from
Oct 6, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 6, 2023 •
edited
Loading

  • we wrap it in our RenderTarget, but do not own it so avoid destroying it.
  • this was creating an error when exiting from the XR
    image

@mvaligursky mvaligursky self-assigned this Oct 6, 2023
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Oct 6, 2023
@mvaligursky mvaligursky merged commit 3fc8bf0 into main Oct 6, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-dont-delete-backbuffer branch October 6, 2023 16:03
mvaligursky added a commit that referenced this pull request Oct 12, 2023
@mvaligursky
[Fix] Don’t delete the framebuffer owned by the context (#5728)
bdd79b3 
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@willeastcott willeastcott Awaiting requested review from willeastcott

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck