Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate and enforce valid texture dimensions #5683

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Validate and enforce valid texture dimensions #5683

merged 2 commits into from
Sep 27, 2023

Conversation

mvaligursky
Copy link
Contributor

Fractions break few things, so avoid them.

@mvaligursky mvaligursky self-assigned this Sep 27, 2023
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Sep 27, 2023
willeastcott
willeastcott reviewed Sep 27, 2023
View reviewed changes
src/core/math/math.js Outdated Show resolved Hide resolved
@mvaligursky mvaligursky merged commit 93fa36f into main Sep 27, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-texture-size-valid branch September 27, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@marklundin marklundin Awaiting requested review from marklundin

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott