Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup to the way antialiasing set up is handled #5679

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Small cleanup to the way antialiasing set up is handled #5679

merged 1 commit into from
Sep 26, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Sep 26, 2023 •
edited
Loading

Fixes #5455

  • more unified across devices
  • no longer read backbuffer samples, as we always request single-sampled back-buffer, and handle multi-sampling internally.

@mvaligursky mvaligursky self-assigned this Sep 26, 2023
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Sep 26, 2023
@mvaligursky mvaligursky merged commit e5fa96b into main Sep 26, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-antialias-cleanup branch September 26, 2023 15:47
@kungfooman kungfooman mentioned this pull request Oct 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@willeastcott willeastcott Awaiting requested review from willeastcott

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Huawei RenderTarget to RGBA16F with MAX_SAMPLES - failing to attach framebuffer.
2 participants
@mvaligursky @slimbuck