Internal variable renamed for consistency with next updates #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| app.on("update", function (dt) { | ||
|
|
||
| c++; |
There was a problem hiding this comment.
I did a double-take here. C++? This is JavaScript!
There was a problem hiding this comment.
right? sorry removing changes to this file, c++ just won't do it.
Comment on lines
281
to
282
|
|
||
|
|
There was a problem hiding this comment.
What's with all the whitespace? 😄
Comment on lines
279
to
280
| pc.Tracing.set(pc.TRACEID_RENDER_PASS, c === 20); | ||
| pc.Tracing.set(pc.TRACEID_RENDER_PASS_DETAIL, c === 20); |
There was a problem hiding this comment.
Feels like you didn't mean to include changes to this example in your PR?
| @@ -0,0 +1,11 @@ | |||
| import { RenderPass } from "../../platform/graphics/render-pass.js"; | |||
There was a problem hiding this comment.
Is this file meant to be in the PR?
There was a problem hiding this comment.
nope :(
too keen to get that rename going. This is next PR, sorry.
willeastcott
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a rename