Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored and fixed the lightcube lighting for particle emitters #5570

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Refactored and fixed the lightcube lighting for particle emitters #5570

merged 3 commits into from
Aug 17, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Aug 17, 2023 •
edited
Loading

Refactored code to a separate class. Fixed issues:

  • light cube evaluated per emitter and per layer, instead of just per layer
  • only the last cube evaluated was ever used due to setting up the uniform before all rendering, instead of per layer during rendering
  • we only allocate a single instance now instead of one per layer and one per emitter

@mvaligursky mvaligursky self-assigned this Aug 17, 2023
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Aug 17, 2023
@mvaligursky mvaligursky merged commit e4731b0 into main Aug 17, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-light-cube branch August 17, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott