Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer composition does not maintain list of shadow casters per light #5540

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Layer composition does not maintain list of shadow casters per light #5540

merged 7 commits into from
Aug 10, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Aug 3, 2023 •
edited
Loading

follow up to #5536
contains changes already approved here: #5549 (sorry about it, read the details there)

  • shadow casters for culling are fetched from layers directly, to avoid expensive composition update when a caster mesh instance is added to a layer.

@mvaligursky mvaligursky self-assigned this Aug 3, 2023
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue labels Aug 3, 2023
@mvaligursky mvaligursky mentioned this pull request Aug 3, 2023
Closed
Martin Valigursky and others added 2 commits August 4, 2023 10:15
@mvaligursky mvaligursky mentioned this pull request Aug 4, 2023
Merged
mvaligursky and others added 2 commits August 10, 2023 20:19
@mvaligursky @willeastcott
Update src/scene/renderer/shadow-renderer.js
ec28fdc 
Co-authored-by: Will Eastcott <will@playcanvas.com>
lint
144b78f
@mvaligursky mvaligursky merged commit b18e198 into main Aug 10, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-composition-casters branch August 10, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue performance Relating to load times or frame rate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott