Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): rollup type completion - lint warnings #5539

Merged
merged 2 commits into from
Aug 3, 2023
Merged

chore(examples): rollup type completion - lint warnings #5539

merged 2 commits into from
Aug 3, 2023

Conversation

epreston
Copy link
Contributor

@epreston epreston commented Aug 3, 2023

add type completion for rollup
jsdoc for inline plugin
address lint warnings
explicit __dirname so this can be used as umd or cjs

Fixes lint warnings.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

add type completion for rollup
jsdoc for inline plugin
address lint warnings
correct name spacing
examples/rollup.config.js Show resolved Hide resolved
@willeastcott willeastcott merged commit 26923c4 into playcanvas:main Aug 3, 2023
7 checks passed
@epreston epreston deleted the examples-jsdocs branch August 3, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants