Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to the LitShader compatibility handling #5533

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Aug 1, 2023

  • removing as it overrides function set in the deprecated, and lint does not allow it without an assignment

follow up to my lint fix in #5494

@mvaligursky mvaligursky self-assigned this Aug 1, 2023
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Aug 1, 2023
@kungfooman
Copy link
Collaborator

I only added it for the sake of having it typed, so it's okay to just drop it 👍

@mvaligursky mvaligursky merged commit 69acbed into main Aug 1, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-fix-chunk-fixups branch August 1, 2023 13:01
mvaligursky added a commit that referenced this pull request Aug 1, 2023
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants