Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GPU particles on Mali G52 due to rendering artifacts #5255

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

yaustar
Copy link
Contributor

@yaustar yaustar commented Apr 20, 2023

Also enabled Samsung devices again as they no longer have issues rendering GPU particles except for G52

See thread: https://forum.playcanvas.com/t/particles-not-rendered-on-amazon-fire-tablet-hd-8/30660

Test project with the updated check: https://playcanv.as/b/9faf8adb

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Also enabled Samsung devices again as they no longer have issues rendering GPU particles except for G52
@yaustar yaustar added bug release: next patch Ticket marked for next patch release area: particles labels Apr 20, 2023
@yaustar yaustar requested a review from a team April 20, 2023 10:56
@yaustar yaustar self-assigned this Apr 20, 2023
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@yaustar yaustar merged commit 1af7fae into main Apr 24, 2023
@yaustar yaustar deleted the gpu-particles-disable-mali-g52 branch April 24, 2023 09:53
mvaligursky pushed a commit that referenced this pull request Apr 24, 2023
* Disable GPU particles on Mali G52

Also enabled Samsung devices again as they no longer have issues rendering GPU particles except for G52

* Removed unused VAR

* Removed trailing spaces

---------

Co-authored-by: Steven Yau <syau@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: particles bug release: next patch Ticket marked for next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants