Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Warn and block Entity transform when Dynamic Rigid Body present (#5069)" #5254

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

yaustar
Copy link
Contributor

@yaustar yaustar commented Apr 18, 2023

This reverts commit 003ab99.

Fixes #5252

@MushAsterion We've had to revert this as it also fired warnings for 'getPosition()' on entity. See more here: https://forum.playcanvas.com/t/rigidbody-lookat/30630

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

…nt (#5069)"

This reverts commit 003ab99.

# Conflicts:
#	src/scene/graph-node.js
@yaustar yaustar requested a review from a team April 18, 2023 10:11
@yaustar yaustar self-assigned this Apr 18, 2023
@yaustar yaustar added bug release: next patch Ticket marked for next patch release labels Apr 18, 2023
@yaustar yaustar merged commit 2d75cf8 into main Apr 18, 2023
@yaustar yaustar deleted the revert-warn-block-dynamic-rigidbody branch April 18, 2023 12:32
mvaligursky pushed a commit that referenced this pull request Apr 24, 2023
…nt (#5069)" (#5254)

* Revert "Warn and block Entity transform when Dynamic Rigid Body present (#5069)"

This reverts commit 003ab99.

# Conflicts:
#	src/scene/graph-node.js

* Fixed merge conflict error

---------

Co-authored-by: Steven Yau <syau@snapchat.com>
# Conflicts:
#	src/scene/graph-node.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release: next patch Ticket marked for next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic rigidbody dirty transform warning shouldn't be showing when changing scale?
3 participants