Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for face-culling to WebGPU #5221

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Added support for face-culling to WebGPU #5221

merged 2 commits into from
Mar 31, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Mar 31, 2023 •
edited
Loading

WebGPU now honour the face-culling settings while rendering.

Additionally:

  • deprecated GraphicsDevice.getCullMode in a move to more stateless device. Before rendering, a culling needs to be set, but it does not need to restored afterwords.
  • deprecated not very useful constant CULLFACE_FRONTANDBACK, which is not supported by WebGPU. It's also not exposed on the material in the Editor, and its result is the mesh simple not getting rendered. Note that it is still functional on WebGl device, but no longer publicaly exposed.

@mvaligursky mvaligursky self-assigned this Mar 31, 2023
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Mar 31, 2023
@mvaligursky mvaligursky merged commit d61eb79 into main Mar 31, 2023
@mvaligursky mvaligursky deleted the mv-webgpu-face-culling branch March 31, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott