Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further cleanup / optimization to the way face culling is handled #5207

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Further cleanup / optimization to the way face culling is handled #5207

merged 1 commit into from
Mar 29, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Mar 29, 2023 •
edited
Loading

  • moved shared scaleSign getter to Mat4
  • passing face culling as a number (-1 or 1) instead of bool which we need to convert to numbers, to speed up per frame cost.

@mvaligursky mvaligursky self-assigned this Mar 29, 2023
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue labels Mar 29, 2023
@mvaligursky mvaligursky merged commit 36b3ccc into main Mar 29, 2023
@mvaligursky mvaligursky deleted the mv-culling-cleanup branch March 29, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue performance Relating to load times or frame rate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott