Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and workarounds to bring multiple examples to work on WebGPU #5170

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Mar 20, 2023

Enabled WebGPU for examples:
- post-effects
- clustered area lights
- ground fog

Added support for options.antialias when creating WebGPU device, instead of always using multisampling.

Workarounds:

  • on WebGPU we don't have a support for depth buffer resolve with this is multi-sampled. We need to implemented a shader based resolve, to have access to scene depth. For now, in the examples that need scene depth, multisampling has been turned off.
  • added workaround for storing multisampled color when the same multisampled buffer is rendered to multiple times. Needs better solution.

Improved render pass logging - moved it from FrameGraph logging to logging during rendering, to log data for render passes that are not part of FrameGraph yet (ad-hoc render passes). This allows us to see render passes from post-effects and similar:

Screenshot 2023-03-20 at 12 08 16

@mvaligursky mvaligursky self-assigned this Mar 20, 2023
@mvaligursky mvaligursky merged commit 039238b into main Mar 20, 2023
@mvaligursky mvaligursky deleted the mv-webgpu-examples-fixes branch March 20, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants