Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http arrayBuffer fix #5165

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Http arrayBuffer fix #5165

merged 1 commit into from
Mar 20, 2023

Conversation

slimbuck
Copy link
Member

Currently, when requesting an arrayBuffer download of files served with content application/json, http handler attempts to access xhr.responseText which results in an error being thrown.

(This error is currently firing when loading a gltf file from a server which specifies gltf with content type application/json).

This PR changes the test order to handle binary first.

@slimbuck slimbuck requested a review from a team March 17, 2023 21:07
@slimbuck slimbuck self-assigned this Mar 17, 2023
@slimbuck slimbuck merged commit f70d9cc into playcanvas:main Mar 20, 2023
@slimbuck slimbuck deleted the http-binary-fix branch March 20, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants