-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Examples Browser] Support device type switching #5147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
Mar 13, 2023
This reverts commit 818a8d7.
mvaligursky
reviewed
Mar 14, 2023
mvaligursky
reviewed
Mar 14, 2023
mvaligursky
reviewed
Mar 14, 2023
mvaligursky
reviewed
Mar 15, 2023
mvaligursky
reviewed
Mar 15, 2023
mvaligursky
reviewed
Mar 15, 2023
mvaligursky
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, cannot wait to test this.
Left few suggestions before merging.
mvaligursky
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for graphics device type switching in the examples browser. Users can choose to run each example using WebGL 1, WebGL 2 or WebGPU.
The browser will attempt to run the current example using the selected device, however if that device is not usable for a given example a fallback device will be used instead. This will be displayed to the user as follows:
If the user selects an unsupported device type, then switches to an example which can use that device type, their selection will be restored. This allows a user to click through both WebGL and WebGPU examples while keeping track of their preferred device type.
Only examples with the following property set will support the WebGPU device type. This will allow us to progressively enable WebGPU in different examples as its support matures.
Fixes #5027
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.