Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily evaluate disjoint timer extension #5139

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

mvaligursky
Copy link
Contributor

This extension is not typically needed in builds without GPU profiling, so evaluate the extension lazily to avoid the cost at start up.

@mvaligursky mvaligursky self-assigned this Mar 9, 2023
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue labels Mar 9, 2023
@mvaligursky mvaligursky merged commit 8d92f28 into main Mar 9, 2023
@mvaligursky mvaligursky deleted the mv-extension-timer-lazy branch March 9, 2023 16:38
@willeastcott
Copy link
Contributor

Shouldn't we have a generic approach to lazily wrangling all WebGL extensions? I had considered this in the past but never got around to it. Obviously, some extensions will be required in all circumstances....but it still might be worth doing this across the board for consistency.

@mvaligursky
Copy link
Contributor Author

Ideally yes, but that's a larger job. I addressed a specific bottleneck in the app I profiled. We only have 2 extensions on WebGl 2, and the other one is often required, so this is the only saving on WebGL2 here. WebGl 1 is a separate story, with lots of extensions, but I didn't go there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue performance Relating to load times or frame rate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants