Fix the destroy callback in Bloom #5077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. Is now a good time to do an audit to check if all post effects are correctly freeing any allocated resources? |
It looks like render targets are being removed in other post effects while destroying |
|
But shaders (WebGL programs) are not removed. |
willeastcott
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Approving, but I'll leave it to @mvaligursky to merge. 😄 Thanks!
mvaligursky
approved these changes
Feb 21, 2023
mvaligursky
pushed a commit
that referenced
this pull request
Feb 23, 2023
* Fix the destroy callback in Bloom * Review comment: #5077 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_destroy is defined in this.effect.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.