-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for WebGPU #5029
Add types for WebGPU #5029
Conversation
I tried adding those before, fingers crossed you get it to work. Lines 37 to 57 in f1770e4
|
@mvaligursky Seems to work. Can you maybe verify for yourself using this branch? Remember to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, seems to work great! I added some types back in, will do the rest in a separate PR when this is merged.
"GPUBindGroupDescriptor": "readonly", | ||
"GPUBindGroupLayout": "readonly", | ||
"GPUBlendState": "readonly", | ||
"GPUBuffer": "readonly", | ||
"GPUBufferUsage": "readonly", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these 4 should be removed as well I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter complains if you remove those 4.
Add IntelliSense support for WebGPU types:
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.