Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize clustered lighting shaders compilation time on Windows platform #5012

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Optimize clustered lighting shaders compilation time on Windows platform #5012

merged 2 commits into from
Jan 27, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 27, 2023 •
edited
Loading

  • using A8 instead of RGBA8 texture format to store light indices, which means a single texel stores a single light index, instead of 4. This allows the inner loop over 4 lights per pixel to be removed. Measured compilation speedup of 30-40% on Windows, both with and without area lights.
  • small refactor of texture to allow WebGPU support for A8 texture.

willeastcott
willeastcott approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incredible. Awesome speedup! 🏃

@mvaligursky mvaligursky merged commit 2a39488 into main Jan 27, 2023
@mvaligursky mvaligursky deleted the mv-cluster-remove-loop branch January 27, 2023 12:33
@mvaligursky mvaligursky mentioned this pull request Jan 27, 2023
Open
@mvaligursky mvaligursky mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott