Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix to non-clustered omni shadow rendering #4972

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 12, 2023

Sorts out an issue introduced here: #4958

  • only calls this.updateLightTextureAtlas for clustered lights

Additionally

  • in Lights example adds a missing handler to load cookie cubemap
  • does not increment _shadowMapUpdates unless the shadow actually renders
  • added error when texture required by the uniform is missing, as that causes hard to debug issues like this:

Screenshot 2023-01-11 at 17 51 37

Now we get a lot more useful engine errors
Screenshot 2023-01-12 at 11 13 48

@mvaligursky mvaligursky self-assigned this Jan 12, 2023
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Jan 12, 2023
@mvaligursky mvaligursky merged commit d352818 into main Jan 12, 2023
@mvaligursky mvaligursky deleted the mv-shadow-fixes branch January 12, 2023 13:17
slimbuck pushed a commit that referenced this pull request Jan 12, 2023
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants