Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix null access caused in clustered light code when no meshes use lights #4956

Merged
merged 1 commit into from
Jan 9, 2023
Merged

[Fix] Fix null access caused in clustered light code when no meshes use lights #4956

merged 1 commit into from
Jan 9, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 9, 2023 •
edited
Loading

Fixes #4950

Caused by keeping a reference to released WorldClusters in case a layer no longer has meshes, instead of setting it to null.

@mvaligursky mvaligursky self-assigned this Jan 9, 2023
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Jan 9, 2023
yaustar
yaustar approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@yaustar yaustar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. lightClusters is not a getter so there's no extra logic being ran under the hood

@mvaligursky mvaligursky merged commit d7d3fcc into main Jan 9, 2023
@mvaligursky mvaligursky deleted the mv-clustered-no-meshes-fix branch January 9, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaustar yaustar yaustar approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabling a model Entity with Clustered lighting gives errors
2 participants
@mvaligursky @yaustar