Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of some path's methods #4943

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Improve performance of some path's methods #4943

merged 2 commits into from
Dec 20, 2022

Conversation

querielo
Copy link
Contributor

@querielo querielo commented Dec 20, 2022 •
edited
Loading

The PR improves performance, simplify methods, don't create temporal arrays.

@willeastcott willeastcott added the performance Relating to load times or frame rate label Dec 20, 2022
mvaligursky
mvaligursky approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thanks!

@mvaligursky mvaligursky merged commit 541f6f0 into playcanvas:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees
No one assigned
Labels
performance Relating to load times or frame rate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@querielo @mvaligursky @willeastcott