WebGPU support for rendering to shadow map for Directional lights #4924
Conversation
mvaligursky
changed the title
| destroy() { | ||
| this.viewBindGroups.forEach((bg) => { | ||
| bg.defaultUniformBuffer.destroy(); | ||
| bg.destroy(); | ||
| }); | ||
| this.viewBindGroups.length = 0; |
There was a problem hiding this comment.
Wouldn't it make sense to delete bg.defaultUniformBuffer in BindGroup#destroy instead? It feels like BindGroup#destroy isn't doing a full job when you still need to delete internal properties yourself first.
There was a problem hiding this comment.
It's a property value I assign to it, but it does not own it, as multiple bindGroups can use the same uniform buffer. If JS had some easier way to do ref counting, this would be ref counted perhaps.
It's similar to how when you create a render target, you give it color buffer, but you need to destroy it even when RT itself is destroyed.
There was a problem hiding this comment.
actually, a material -> texture is even more similar to this. Texture, as well as Uniform Buffer is a buffer GPU resource. Material does not own it, it does not destroy it, only uses it. Same here. In this specific instance, there is only one user of this uniform buffer, so I destroy it, but that's not a case in general.
WebGPU platform can render to a shadow map for directional light. The shadow map cannot be still used to sample from, that would be done in a follow up PR.
Part of the changes is refactoring of ShadowRendererLocal and ShadowRendererDirectional - those no longer extend the ShadowRenderer, but share a single instance of it, to limit some resource duplication.