GrabPass functionality changes to support WebGPU and improve WebGL support #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
approved these changes
Nov 30, 2022
| // texture format of the source texture the grab pass needs to copy | ||
| getSourceColorFormat(texture) { | ||
| // based on the RT the camera renders to, otherwise framebuffer | ||
| return texture?.format ?? this.device.framebufferFormat; |
There was a problem hiding this comment.
?? just looks so weird as an or operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thisin SceneGrab #4399This is all tested for all Webgl 1 & 2, post-effects & not, and alpha & opaque framebuffer combinations.