Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ClusteredAreaLIghts to use createGraphicsDevice function #4887

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Updated ClusteredAreaLIghts to use createGraphicsDevice function #4887

merged 2 commits into from
Nov 24, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Nov 24, 2022 •
edited
Loading

  • only converted, no other changes
  • changed warning to error when a hander is missing, as otherwise its easy to miss and stuff does not load.

This now works on WebGPU
Screenshot 2022-11-24 at 16 19 30

@mvaligursky mvaligursky self-assigned this Nov 24, 2022
@mvaligursky mvaligursky merged commit ec17e1f into main Nov 24, 2022
@mvaligursky mvaligursky deleted the mv-clustered-area-lights-update branch November 24, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@ellthompson ellthompson Awaiting requested review from ellthompson

@willeastcott willeastcott Awaiting requested review from willeastcott

Assignees

@mvaligursky mvaligursky

Labels
area: examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck