Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to asset viewer example #4823

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Minor improvements to asset viewer example #4823

merged 1 commit into from
Nov 7, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Nov 7, 2022 •
edited
Loading

  • tweaked lighting to make the assets stand out more
  • tweaked text placement to be on the ground instead of above
  • replaced the drop down asset selector with previous / next buttons for faster interaction

before
Screenshot 2022-11-07 at 12 32 33

now
https://user-images.githubusercontent.com/59932779/200311808-c4dcc955-7af0-445e-b859-cd48ee38c22f.mov

@mvaligursky mvaligursky self-assigned this Nov 7, 2022
@mvaligursky mvaligursky merged commit 4bf8eee into main Nov 7, 2022
@mvaligursky mvaligursky deleted the mv-asset-viewer-example-update branch November 7, 2022 12:28
mvaligursky added a commit that referenced this pull request Nov 7, 2022
@mvaligursky
Minor improvements to asset viewer example (#4823)
1fec265 
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSterbrant GSterbrant GSterbrant approved these changes

@willeastcott willeastcott Awaiting requested review from willeastcott

Assignees

@mvaligursky mvaligursky

Labels
area: examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvaligursky @willeastcott @GSterbrant