Audio resume fix

[slimbuck]

Fixes #4760

iOS doesn't correctly resume on touchend event, but does on touchstart event.

This PR also simplifies manager suspend/resume logic a bit.

API Changes:

• removed SoundManager options object

[willeastcott]

What about these lines:

https://github.com/playcanvas/engine/pull/4788/files#diff-bf489dbc39f80880f4921c574a985e18d6abd0c6716cd3d2907dbb96ed37e255R31-R32

That's public API:

https://developer.playcanvas.com/api/pc.SoundManager.html#SoundManager

So presumably this PR actually removes that option? I'm fine with that (to be honest, I'm not sure why anyone would want to use that option!). But if this is so, the docs should be updated.

[slimbuck]

So presumably this PR actually removes that option? I'm fine with that (to be honest, I'm not sure why anyone would want to use that option!). But if this is so, the docs should be updated.

Oh yes, that code just didn't make any sense (and I assumed this was some legacy workaround). Perhaps I should investigate the origin of that option first and then decide whether to remove it entirely.

[slimbuck]

The force option was added here
and doesn't appear to have ever done anything.

So do I just remove the jsdoc?

[willeastcott]

Sure, but also the whole options object from the code (plus passing it in application.js) since that was the only option. 😄

[slimbuck]

Sure, but also the whole options object from the code (plus passing it in application.js) since that was the only option. 😄

Done!

[willeastcott]

OK, LGTM now. Nice job! 🙌

[willeastcott]

But maybe call out the API change in the PR description!

[slimbuck]

Thanks for your help @willeastcott !